Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MODELS_INFO to all v1 quirks #2736

Open
TheJulianJES opened this issue Nov 9, 2023 · 2 comments
Open

Add MODELS_INFO to all v1 quirks #2736

TheJulianJES opened this issue Nov 9, 2023 · 2 comments
Labels
code quality Improvement to code quality enhancement Improve an existing quirk no stale Bot won't close issue/PR even if inactive

Comments

@TheJulianJES
Copy link
Collaborator

TheJulianJES commented Nov 9, 2023

Some quirks do not provide MODELS_INFO (and also not MODEL or MANUFACTURER).
These quirks should be updated to provide one of the above if possible.
It might be hard to get all matching model/manufacturer names though.

A test was added in this PR which also exempts some quirks:

Additional information

Collection of PRs/commit that were missing model info:

PRs:

@TheJulianJES TheJulianJES added enhancement Improve an existing quirk code quality Improvement to code quality labels Nov 9, 2023

This comment has been minimized.

@github-actions github-actions bot added the stale Issue is inactivate and might get closed soon label May 8, 2024
@TheJulianJES TheJulianJES removed the stale Issue is inactivate and might get closed soon label May 8, 2024
@TheJulianJES TheJulianJES changed the title Add MODELS_INFO to all quirks Add MODELS_INFO to all v1 quirks May 8, 2024
Copy link

github-actions bot commented Nov 4, 2024

There hasn't been any activity on this issue recently. Due to the high number of incoming GitHub notifications, we have to clean some of the old issues, as many of them have already been resolved with the latest updates. Please make sure to update to the latest version and check if that solves the issue. Let us know if that works for you by adding a comment 👍 This issue has now been marked as stale and will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the stale Issue is inactivate and might get closed soon label Nov 4, 2024
@TheJulianJES TheJulianJES removed the stale Issue is inactivate and might get closed soon label Nov 4, 2024
@TheJulianJES TheJulianJES added the no stale Bot won't close issue/PR even if inactive label Nov 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Improvement to code quality enhancement Improve an existing quirk no stale Bot won't close issue/PR even if inactive
Projects
None yet
Development

No branches or pull requests

1 participant