std: use math overflow helpers instead of builtins
#18165
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nektro
approved these changes
Nov 30, 2023
Vexu
reviewed
Nov 30, 2023
Comment on lines
+19
to
+20
| const mask = try math.shlExact(U, byte & 0x7f, group * 7); | ||
| value |= mask; |
There was a problem hiding this comment.
My understanding is that Andrew prefers to use builtins when available. These should instead be changed to use the destructuring syntax #498:
Suggested change
| const mask = try math.shlExact(U, byte & 0x7f, group * 7); | |
| value |= mask; | |
| const mask, const overflow = @shlWithOverflow(@as(U, byte & 0x7f), group * 7); | |
| if (overflow != 0) return error.Overflow; | |
| value |= mask; |
There was a problem hiding this comment.
Hmm, I am confused. I feel like that would make sense if you were using overflow for bit stuff. However, we seem to be just checking if there wasn't an overflow. Therefore, does it not make much more sense to use the "zig" approach with try?
As a side note, this also removes the need for prerequisite knowledge for how overflow bits behave (even if they seem simple to some people).
andrewrk
force-pushed
the
feat-remove-raw-overflows
branch
from
d0c9fd0 to
3481c47
Compare
sno2
force-pushed
the
feat-remove-raw-overflows
branch
from
3481c47 to
7804828
Compare
This patch replaces all usages of the `@___WithOverflow` builtins where the overflow result is discarded with the nicer `math` helpers that return `error.Overflow`. This cleaned up a bit of code and hopefully impresses the useful `math` functions on more Zig code later.
sno2
force-pushed
the
feat-remove-raw-overflows
branch
from
7804828 to
ff8eb83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch replaces all usages of the
@___WithOverflowbuiltins where the overflow result is simply read for erroring with the nicermathhelpers that returnerror.Overflow. This cleaned up a bit of code and hopefully impresses the usefulmathfunctions on more Zig code later.