Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I welcome Suggestions/Criticism/Edits/Additions. #2

Open
zhdenny opened this issue Sep 10, 2024 · 8 comments
Open

I welcome Suggestions/Criticism/Edits/Additions. #2

zhdenny opened this issue Sep 10, 2024 · 8 comments

Comments

@zhdenny
Copy link
Owner

zhdenny commented Sep 10, 2024

Title says it all.....if you see something, let me know.

@zhdenny zhdenny pinned this issue Sep 10, 2024
@jctull
Copy link

jctull commented Nov 27, 2024

In your readme, when you say the import will overwrite ingredients, etc., does that mean just the ones with same names or everything? Thanks

@zhdenny
Copy link
Owner Author

zhdenny commented Nov 27, 2024

When you import a bar into your Bar Assistant instance, you have two options.

  1. Import into a brand new Bar
  2. Import into an existing Bar.

Option 1 is self explanatory. Option 2 is a complete overwrite. EVERYTHING is completely overwritten in the bar you choose.

There is no other option offered by the developer. But, just to be clear, if you want to ALSO have your own cocktails/ingredients, you can totally create a completely separate bar from mine. Bar Assistant supports MULTIPLE bars.

The idea behind this GitHub repo is you import my bar into a new bar called something like "zhdenny bar". And you don't touch it. Just use it but do not edit/modify it. Only update it occasionally to get the latest changes from me.

Then separate from all of that, you can create/edit/use an additional Bar that is all you to take care of. Make sense?

@necromancyr
Copy link

So, just did an import into an existing bar and it doesn't actually overwrite everything - caught it with Cynar. Basically, had Cynar on my bar shelf, and instead of replacing/removing it, I had the default Cynar and your named version ([Cynar Artichoke Liqueur).

And it seems to do odd things w/recipes that exist in both - it adds, but doesn't overwrite. Valkerie, for example, still shows up as Cynar even though it's in your bar database (when ingested into a clean bar).

So...logic is not what you had above - not exactly sure what it is however.

@zhdenny
Copy link
Owner Author

zhdenny commented Jan 14, 2025

Your very first import should be into a NEW BAR.

After that, if you want to keep up-to-date with new stuff I add, you can continue to import overwriting that new bar.

Thanks for bringing this up. I'll add that into the Readme instructions

@necromancyr
Copy link

That makes a ton of sense, thanks! And thanks for the great work on this - I was thinking of making edits like you have given the need for much more specificity for Tiki drinks re: rums.

@zhdenny
Copy link
Owner Author

zhdenny commented Jan 14, 2025

Lemme know if you see something you think should be added or changed and I'll consider it.
I'm always adding stuff. But I try to avoid cocktails that have TOO MUCH custom/homemade ingredients.

@necromancyr
Copy link

Will do - key thing for me is finding a way to get a ton of recipes/cocktails imported quickly (e.g., Smuggler's Cove, Modern Tiki, Don's books, Cocktail Codex, Death & Co, etc.). :)

@zhdenny
Copy link
Owner Author

zhdenny commented Jan 14, 2025

When I add a cocktail, I give credit to the Bartender, Bar, Location, Book etc....so often you'll see drinks in my database which comes from those sources you mentioned.

But I admit, while I own some of those books, I don't go page for page adding every drink from the book into my database. I cherry pick.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants