Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions about the definition of some variables #16

Open
666github100 opened this issue Oct 27, 2023 · 1 comment
Open

Questions about the definition of some variables #16

666github100 opened this issue Oct 27, 2023 · 1 comment

Comments

@666github100
Copy link

Dear reseracher, sorry to bother you. I have carefully reviewed the code in your github and have some questions. May I discuss them with you?

  1. Regarding the definition of action values. I discoverd that there are 8 types (from 0 to 7) in your code, which are directly obtained from the simulation environment. I would like to ask the meaning of these 8 types of actions. I have seen many papers before that have 4 types of actions, such as colight ;
  2. Regarding the travel time . In metric file , travel_time = current_time - self.vehicle_enter_time[vehicle] ,why not use the leave_time-enter_time?
  3. Regarding the design of reward,in the maddpg algorithm, the design of rewards : reward+=(self. action==self. last_action) * 2. What is the reason for that?
    If you could reply to me amidst your busy schedule, I would be very grateful!
@BackMountainDevil
Copy link

action space: according the CityFlow/examples/roadnet.json. the intersection_1_1's trafficLight has 8 lightphases. each phase allow specific roads pass. that is my opinion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants