Skip to content

Commit 35993fe

Browse files
zhangskzcopybara-github
authored andcommitted
Update package.xml to include link to specific release notes.
PiperOrigin-RevId: 486774822
1 parent 60b7149 commit 35993fe

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

php/BUILD.bazel

+2-1
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ load("@rules_pkg//:pkg.bzl", "pkg_tar")
77
load("@upb//cmake:build_defs.bzl", "staleness_test")
88
load("//build_defs:internal_shell.bzl", "inline_sh_binary")
99
load("//conformance:defs.bzl", "conformance_test")
10-
load("//:protobuf_version.bzl", "PROTOBUF_PHP_VERSION")
10+
load("//:protobuf_version.bzl", "PROTOBUF_PHP_VERSION", "PROTOC_VERSION")
1111

1212
filegroup(
1313
name = "source_files",
@@ -192,6 +192,7 @@ genrule(
192192
"$(location ext/google/protobuf/generate_package_xml.sh)",
193193
"$(location ext/google/protobuf/template_package.xml)",
194194
PROTOBUF_PHP_VERSION,
195+
PROTOC_VERSION,
195196
"$$(tar -tf $(location :release_without_package) | sed -z -e 's;\\n;,;g')",
196197
"$(location package.xml)"
197198
]),

php/ext/google/protobuf/generate_package_xml.sh

+4-2
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,9 @@
22

33
template_package_xml=$1
44
release_version=$2
5-
release_files=$3
6-
out=$4
5+
protoc_version=$3
6+
release_files=$4
7+
out=$5
78

89
date=$(date +%Y-%m-%d)
910
time=$(date +%H:%M:%S)
@@ -36,4 +37,5 @@ sed -e "s;TEMPLATE_TIME;${time};" |
3637
sed -e "s;TEMPLATE_PHP_RELEASE;${release_version};" |
3738
sed -e "s;TEMPLATE_PHP_API;${api_version};" |
3839
sed -e "s;TEMPLATE_PHP_STABILITY;${stability};g" |
40+
sed -e "s;TEMPLATE_PROTOC_VERSION;${protoc_version};" |
3941
sed -e "s;TEMPLATE_FILES;${files};" > $out

php/ext/google/protobuf/template_package.xml

+1-1
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
</stability>
2323
<license uri="https://opensource.org/licenses/BSD-3-Clause">BSD-3-Clause</license>
2424
<notes>
25-
* See github.com/protocolbuffers/protobuf/releases for release notes.
25+
* See github.com/protocolbuffers/protobuf/releases/tag/vTEMPLATE_PROTOC_VERSION for release notes.
2626
</notes>
2727
<contents>
2828
<dir baseinstalldir="/" name="/">TEMPLATE_FILES</dir>

0 commit comments

Comments
 (0)