Stream Enabled Clients Do Not Need Close Handler #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The call to `EventBroker.prototype.client` checks the given `client` instance for `streamEnabled`. If "true", the client is passed to `_streamEnabledClient` where it has "close" and "unsubscribe" event handlers added. If the client is *not* `streamEnabled` the event handlers are *not* added. This means that the `_subscribe` method only needs to make sure to call unsubscribe on the "close" event of clients that are not `streamEnabled`.
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The call to
EventBroker.prototype.clientchecks the givenclientinstance for
streamEnabled. If "true", the client is passed to_streamEnabledClientwhere it has "close" and "unsubscribe" eventhandlers added. If the client is not
streamEnabledthe eventhandlers are not added.
This means that the
_subscribemethod only needs to make sure tocall unsubscribe on the "close" event of clients that are not
streamEnabled.This PR is to address Issue #351