Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calling a VirtualDevice with no callback function crashes Zetta #240

Closed
kevinswiber opened this issue Oct 5, 2015 · 0 comments
Closed

Calling a VirtualDevice with no callback function crashes Zetta #240

kevinswiber opened this issue Oct 5, 2015 · 0 comments
Assignees
@kevinswiber
Labels
bug core

Comments

@kevinswiber
Copy link
Member

Reported by @mingsheng88 on Gitter (https://gitter.im/zettajs/zetta).

More info: http://dumptext.com/VEVU4FZA

It appears the virtual device attempts to throw an error received by a default callback. When there is no error, Zetta throws undefined, resulting in a crash.
@kevinswiber kevinswiber self-assigned this Oct 5, 2015
@kevinswiber kevinswiber mentioned this issue Oct 5, 2015
Merged
kevinswiber added a commit that referenced this issue Oct 6, 2015
@kevinswiber
Merge pull request #241 from zettajs/fix_240
aa5d987 
Only throw an error in the default VirtualDevice callback if an error has been provided.  Fixes #240.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kevinswiber kevinswiber

Labels
bug core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kevinswiber