Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New colorama release breaks zest.releaser install on Python 3.4. #342

Closed
JPTeasdale opened this issue Jan 21, 2020 · 3 comments
Closed

New colorama release breaks zest.releaser install on Python 3.4. #342

JPTeasdale opened this issue Jan 21, 2020 · 3 comments

Comments

@JPTeasdale
Copy link

JPTeasdale commented Jan 21, 2020

Looks like colorama dropped support for Python 3.4 which means that pip install zest.releaser breaks on python 3.4 as well.

$ pyenv global 3.4.10
$ pip install zest.releaser
Collecting zest.releaser
Collecting colorama (from zest.releaser)
  Using cached https://pypi.uberinternal.com/packages/packages/31/cb/88c908c1be067fb6bacd3d7488ccab1a212533767b951933aac3d22648e2/colorama-0.4.2-py2.py3-none-any.whl
colorama requires Python '>=2.7, !=3.0.*, !=3.1.*, !=3.2.*, !=3.3.*, !=3.4.*' but the running Python is 3.4.10

@reinout
Copy link
Collaborator

reinout commented Jan 22, 2020

I guess the simplest solution is to drop support for 3.4 ourselves, too?
(Or at least stop advertising that we support it and stop running the tests for it).
@mauritsvanrees?

@mauritsvanrees
Copy link
Member

The above error should be fixable by first doing pip install colorama with a version constraint that still works.

I am fine with dropping 3.4 support. I am not using it.

Actually:

  • Our .travis.yml does not test it. It tests 2.7, 3.5, 3.6, and pypy.
  • Our tox.ini tries to test with 3.3+, but I am not using it, might be outdated (could be useful though).
  • Our setup.py claims 2.7 and 3.5+ and PyPy in the classifiers.

So it seems we do not have to do anything (except maybe cleanup tox.ini).

For me personally (and the Plone community in general):

  • Python 2.7 support is very much wanted, but I suspect this will get trickier, for example latest setuptools does not support it. So it is understandable if we drop this at some point this year. But preferably not.
  • Python 3.6, 3.7, 3.8 support is needed. Earlier versions not.
  • PyPy and PyPy3 are nice to have.

@reinout
Copy link
Collaborator

reinout commented Jul 13, 2023

I'm closing the issue, we don't support 3.4 anymore :-)

@reinout reinout closed this as completed Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants