apacheGH-41541: [Go][Parquet] Fix writer performance regression

zeroshade · May 13, 2024 · da58368 · da58368
1 parent f6127a6
commit da58368
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/go/parquet/internal/encoding/types.go b/go/parquet/internal/encoding/types.go
@@ -185,7 +185,7 @@ func (b *PooledBufferWriter) Reserve(nbytes int) {
 		b.buf = bufferPool.Get().(*memory.Buffer)
 	}
 
-	newCap := utils.Max(b.buf.Cap()+b.offset, 256)
+	newCap := utils.Max(b.buf.Cap(), 256)
 	for newCap < b.pos+nbytes {
 		newCap = bitutil.NextPowerOf2(newCap)
 	}

diff --git a/go/parquet/internal/utils/bit_writer.go b/go/parquet/internal/utils/bit_writer.go
@@ -90,8 +90,8 @@ func NewBitWriter(w WriterAtWithLen) *BitWriter {
 func (b *BitWriter) SkipBytes(nbytes int) (int, error) {
 	b.Flush(true)
 	ret := b.byteoffset
+	b.wr.Reserve(nbytes)
 	b.byteoffset += nbytes
-	b.wr.Reserve(b.byteoffset)
 	return ret, nil
 }