Skip to content

Commit fc8d9f5

Browse files
committed
chore: add comments
1 parent 84db9bc commit fc8d9f5

File tree

2 files changed

+14
-1
lines changed

2 files changed

+14
-1
lines changed

core/logx/richlogger.go

+2-1
Original file line numberDiff line numberDiff line change
@@ -206,6 +206,7 @@ func (l *richLogger) WithFields(fields ...LogField) Logger {
206206

207207
func (l *richLogger) buildFields(fields ...LogField) []LogField {
208208
fields = append(l.fields, fields...)
209+
// caller field should always appear together with global fields
209210
fields = append(fields, Field(callerKey, getCaller(callerDepth+l.callerSkip)))
210211
fields = combineGlobalFields(fields)
211212

@@ -235,7 +236,7 @@ func (l *richLogger) buildFields(fields ...LogField) []LogField {
235236

236237
func (l *richLogger) debug(v any, fields ...LogField) {
237238
if shallLog(DebugLevel) {
238-
getWriter().Debug(v, (l.buildFields(fields...))...)
239+
getWriter().Debug(v, l.buildFields(fields...)...)
239240
}
240241
}
241242

core/logx/writer.go

+12
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,27 @@ import (
1717
)
1818

1919
type (
20+
// Writer is the interface for writing logs.
21+
// It's designed to let users customize their own log writer,
22+
// such as writing logs to a kafka, a database, or using third-party loggers.
2023
Writer interface {
24+
// Alert sends an alert message, if your writer implemented alerting functionality.
2125
Alert(v any)
26+
// Close closes the writer.
2227
Close() error
28+
// Debug logs a message at debug level.
2329
Debug(v any, fields ...LogField)
30+
// Error logs a message at error level.
2431
Error(v any, fields ...LogField)
32+
// Info logs a message at info level.
2533
Info(v any, fields ...LogField)
34+
// Severe logs a message at severe level.
2635
Severe(v any)
36+
// Slow logs a message at slow level.
2737
Slow(v any, fields ...LogField)
38+
// Stack logs a message at error level.
2839
Stack(v any)
40+
// Stat logs a message at stat level.
2941
Stat(v any, fields ...LogField)
3042
}
3143

0 commit comments

Comments
 (0)