This repository has been archived by the owner on Jan 24, 2022. It is now read-only.
Check outdated dependencies to push #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbcarpanelli
approved these changes
Jul 18, 2019
|
|
||
| context('when there are dependencies to update', function() { | ||
| it('returns true', function() { | ||
| Dependency.hasDependenciesForDeploy( |
There was a problem hiding this comment.
This is always returning false, as the dependency variable in Dependency.ts#L61 always equals [].
Lemme fix that one for you 🙂
to Dependency#hasDependenciesForDeploy
spalladino
force-pushed
the
fix/push-outdated-deps
branch
from
bfb1c30 to
66cd8f6
Compare
spalladino
added a commit
that referenced
this pull request
Jul 18, 2019
* Check outdated dependencies to push * Allow to send package and network file names to Dependency#hasDependenciesForDeploy
jbcarpanelli
pushed a commit
that referenced
this pull request
Jul 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.