Skip to content

drivers: spi: Initial support for GD32 spi #40416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Mar 29, 2022
Merged

drivers: spi: Initial support for GD32 spi #40416

merged 4 commits into from
Mar 29, 2022

Conversation

@cameled
Copy link
Contributor

@cameled cameled commented Nov 17, 2021 •
edited
Loading

Add initail support for GigaDevice GD32 SPI controller.

More GD32 support can be found in #38657.

[EDIT]
TODO-List:

  • pinctrl for spi, use @gmarull GD32 pinctrl
  • spi_flash sample available for gd32vf103v_eval board
  • software CS, use @gmarull GD32 gpio
  • clock control, for max-frequency check.
    ASYNC support(close this feature)

@github-actions github-actions bot added area: Devicetree area: Devicetree Binding PR modifies or adds a Device Tree binding area: SPI SPI bus labels Nov 17, 2021
@github-actions
Copy link

github-actions bot commented Nov 17, 2021

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
hal_gigadevice zephyrproject-rtos/hal_gigadevice@ce323de zephyrproject-rtos/hal_gigadevice#2 zephyrproject-rtos/hal_gigadevice#2/files

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@nandojve nandojve requested review from gmarull and nandojve November 17, 2021 11:27
@nandojve nandojve mentioned this pull request Nov 22, 2021
Open
55 tasks
@gmarull
Copy link
Member

gmarull commented Nov 22, 2021

@cameled please, rebase. pinctrl is now available, so SPI driver can make use of it.

@github-actions github-actions bot added the area: Samples Samples label Nov 23, 2021
@cameled
Copy link
Contributor Author

cameled commented Nov 23, 2021

please, rebase. pinctrl is now available, so SPI driver can make use of it.

Thanks @gmarull, Looks pinctrl work fine for SPI. I have successfully run the serial flash sample.

gmarull
gmarull reviewed Nov 23, 2021
View reviewed changes
gmarull
gmarull reviewed Nov 23, 2021
View reviewed changes
@cameled cameled force-pushed the gd32-spi branch 3 times, most recently from d39074c to f0b60c7 Compare November 24, 2021 02:12
nandojve
nandojve requested changes Dec 4, 2021
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

@cameled cameled force-pushed the gd32-spi branch 3 times, most recently from e8ab268 to ecaa289 Compare December 7, 2021 01:17
@cameled
Copy link
Contributor Author

cameled commented Jan 23, 2022

Thanks @gmarull, gd32 clock-control on API works fine for gd32-spi driver, test with gd32f450i_eval board on spi_flash sample.
The next step is get_rate API confirmation, I will check it tomorrow.

@cameled
Copy link
Contributor Author

cameled commented Jan 24, 2022

Thanks @gmarull, gd32 clock-control on API works fine for gd32-spi driver, test with gd32f450i_eval board on spi_flash sample. The next step is get_rate API confirmation, I will check it tomorrow.

get_rate API work fine on spi-gd32 driver.

@nandojve
Copy link
Member

nandojve commented Feb 27, 2022 •
edited
Loading

Hi folks,

After a long period of inactivity I think I'll have a little of free time to continue review.
Just to clarify, Is this just waiting clock-control?

BTW, it will require fix CI errors.

@cameled
Copy link
Contributor Author

cameled commented Feb 28, 2022

After a long period of inactivity I think I'll have a little of free time to continue review. Just to clarify, Is this just waiting clock-control?

Yes, the SPI frequency select relay on clock-control.

BTW, it will require fix CI errors.

Sure, It should be fixed. I working on another task now, May be fixed in the end of this week.

@cameled
dts: arm: introduce gd32 spi interface
9025ed9 
Add gd32 spi initial support.

Signed-off-by: HaiLong Yang <[email protected]>
nandojve
nandojve requested changes Mar 19, 2022
View reviewed changes
@carlescufi carlescufi requested a review from gmarull March 21, 2022 14:21
cameled added 2 commits March 24, 2022 15:40
@cameled
drivers: spi: introduce gd32 spi driver
b0f28c8 
Add a simple gd32 spi driver.

Signed-off-by: HaiLong Yang <[email protected]>
@cameled
boards: add gd35q16 flash to gd32f450i_eval and gd32vf103v_eval boards
b8feeec 
Add gd25q16 as "jedec,spi-nor" compatible flash to gd32f450i_eval and
gd32vf103v_eval boards.

Signed-off-by: HaiLong Yang <[email protected]>
gmarull
gmarull previously approved these changes Mar 24, 2022
View reviewed changes
nandojve
nandojve previously approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@nandojve nandojve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you @cameled !

@cameled
samples: spi_flash: add gd32f450i_eval and gd32vf103v_eval boards
ed965a2 
This add gd32f450i_eval and gd32vf103v_eval boards to spi_flash sample.

Signed-off-by: HaiLong Yang <[email protected]>
@cameled cameled dismissed stale reviews from nandojve and gmarull via ed965a2 March 25, 2022 03:01
@cameled
Copy link
Contributor Author

cameled commented Mar 28, 2022

@gmarull @nandojve Could you please re-approve this, I forget to update the commit message. Thanks!

MaureenHelm
MaureenHelm reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@MaureenHelm MaureenHelm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this DNM?

@gmarull gmarull removed the DNM This PR should not be merged (Do Not Merge) label Mar 29, 2022
@gmarull
Copy link
Member

gmarull commented Mar 29, 2022

@MaureenHelm removed DNM, it was still there due to manifest updates that are no longer part of this PR.

@MaureenHelm MaureenHelm merged commit 823b468 into zephyrproject-rtos:main Mar 29, 2022
@str4t0m str4t0m added the platform: GD32 GigaDevice label Aug 26, 2022
@cameled cameled deleted the gd32-spi branch September 1, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MaureenHelm MaureenHelm MaureenHelm approved these changes

@nandojve nandojve nandojve approved these changes

@gmarull gmarull gmarull approved these changes

@nashif nashif Awaiting requested review from nashif

@tbursztyka tbursztyka Awaiting requested review from tbursztyka

@kgugala kgugala Awaiting requested review from kgugala

@pgielda pgielda Awaiting requested review from pgielda

@carlescufi carlescufi Awaiting requested review from carlescufi

@galak galak Awaiting requested review from galak

@mnkp mnkp Awaiting requested review from mnkp

Assignees

No one assigned

Labels

area: API Changes to public APIs area: Boards area: Devicetree Binding PR modifies or adds a Device Tree binding area: Devicetree area: Documentation area: Samples Samples area: SPI SPI bus manifest manifest-hal_gigadevice platform: GD32 GigaDevice

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cameled @gmarull @nandojve @MaureenHelm @str4t0m