Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent auto-receive on initialization #64

Closed
KingGorrin opened this issue Feb 26, 2024 · 0 comments
Closed

Prevent auto-receive on initialization #64

KingGorrin opened this issue Feb 26, 2024 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@KingGorrin
Copy link
Collaborator

The disable auto-receive feature (see #46) has recently been introduced and to maintain compatibility with previous versions, the auto-receive feature has been kept enabled by default.

What’s the problem?
The auto-receive will be enabled whenever you initialize or reset your wallet. This means that it is possible for the wallet to automatically start receiving pending transactions in the time between starting syrius and disabling the auto-receive feature.

The feature to disable the auto-receive is a great function and it's worth to prevent auto-receive on initialization, but enabling privacy by default would probably cause a lot of friction.

How do we fix this?
Firstly, the connection to the node has to be delayed until confirmed on the onboard node-management screen. This has recently been solved in the following PR.

Secondly, present the user with the option to disable the auto-receive feature while onboarding before a connection to the node is confrimed.

The most logical location for this option would be on the onboard node-management screen.

11dcf4f2-35f4-46ba-9ea5-ad522797712e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant