Zend\Cache\Storage\Adapter\Memcache

[cgmartin]

New cache storage adapter for ext/memcache (not to be confused with existing ext/memcached adapter).

Implements feature request: #4481

An example configuration for Zend\Cache\StorageFactory would be:

$memcacheStorageAdapter = \Zend\Cache\StorageFactory::factory(array(
    'adapter' => array(
        'name' => 'memcache',
        'options' => array(
            'compression' => false, // use compression on all writes when able?
            'auto_compress_threshold' => 100,   // compression threshold options
            'auto_compress_min_savings' => 0.2,            
            'servers' => array(
                0 => array('host' => '10.0.0.20', 'port' => 11211), // shorthand, server_defaults will be applied
                1 => array('host' => '10.0.0.21', 'port' => 11211, 'status' => true), 
                2 => array('host' => '10.0.0.22', 'port' => 11211, 'status' => true, 'weight' => 3, 
                           'persistent' => false, 'timeout' => 2, 'retry_interval' => 20), // or can specify all values
            ),
            'server_defaults' => array( 
                // defaults that are applied to servers with missing values
                'weight' => 1,
                'persistent' => true,
                'timeout' => 1,
                'retry_interval' => 15,
            ),
        ),
    ),
));

[samsonasik]

unused use Memcache

[cgmartin]

Thanks for the review, @samsonasik. I think I've gotten everything buttoned up now. Let me know if I've missed anything.

[samsonasik]

👍

[marc-mabe]

This method could be dropped as the memcache extension doesn't support setting items as bulk and setting it as a loop should be done already by the abstract adapter.

[cgmartin]

Thanks. I think I was going cross-eyed from comparing the Memcache/Memcached documentation and was looking at the wrong setMulti page at the time. Will fix.

[marc-mabe]

Only the above comments found.
Looks good - thanks !

[cgmartin]

Thanks @marc-mabe for the review. I think I've got all of your comments addressed, except for the one about booleans that I've replied to. Let me know if there's anything else I've missed. Thanks again.

[cgmartin]

Finished testing differences between ext/memcache 3.x beta and 2.x stable versions, which affects the adapter capabilities: https://github.com/cgmartin/zf2/blob/2c1649e9ca8b7683cd10ad0e65e178a60af49cf5/library/Zend/Cache/Storage/Adapter/Memcache.php#L481-517

[marc-mabe]

I had commented on the method internalRemoveItem to add the second argument to delete fixed as 0 because there was a bug somewhere - My comment goes away but nothing changed yet :/

[marc-mabe]

The lib_options was in the memcached adapter to proxy to Memcached::setOption which changes from version to version. In my opinion it isn't needed for ext/memcache and it would be better to make it a normal getter/setter [get|set]AutoCompressThreshold and [get|set]AutoCompressMinSaving

[cgmartin]

Yeah, I can empathize with that. My original thought was to try make it similar to the Memcached adapter config, but at second glance it just seems awkward here. Will do.

[cgmartin]

@marc-mabe regarding the delete second argument, I looked back through your comments and didn't see anything mentioned about this previously. I found what you are talking about, though, and will make that change:

Delete's second parameter (timeout) is deprecated and not supported.
Values other than 0 may cause delete to fail.
http://www.php.net/manual/memcache.delete.php

[weierophinney]

Merged to develop for release with 2.3.0.