More explicit name for requested name #5755
Conversation
| * @return bool | ||
| */ | ||
| public function canCreateServiceWithName(ServiceLocatorInterface $services, $name, $rName) | ||
| public function canCreateServiceWithName(ServiceLocatorInterface $services, $name, $requestedName) | ||
| { |
There was a problem hiding this comment.
I take this opportunity to ask for the utility of $name variable.
I searched all ZF2 abstract factories, and this variable is never used.
github noob question : is there a way to discuss a line of code without submiting a PR ?
There was a problem hiding this comment.
Sending a mail to the list is the best option. Another one is add a comment in the commit which add that change but we don't recommend that option.
There was a problem hiding this comment.
@jmleroux you can also just link the line of code by clicking on it and pressingY to go to the canonical URI for it.
The mailing list is the best place for discussions indeed
| * @return bool | ||
| */ | ||
| public function canCreateServiceWithName(ServiceLocatorInterface $services, $name, $rName) | ||
| public function canCreateServiceWithName(ServiceLocatorInterface $services, $name, $requestedName) |
There was a problem hiding this comment.
Could you rename $services with $serviceLocator by this way the signature match exactly with the interface.
No description provided.