This repository was archived by the owner on Jan 8, 2020. It is now read-only.
fix #5428 only read the stream contents once #5570
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Only apply the filter once to a stream and when reading the stream use rewind to go to the start of the stream. This seems to fixes the issue. |
| @@ -79,6 +80,7 @@ public function getEncodedStream($EOL = Mime::LINEEND) | |||
| //stream_filter_remove(); // ??? is that right? | |||
| switch ($this->encoding) { | |||
| case Mime::ENCODING_QUOTEDPRINTABLE: | |||
| if(array_search(Mime::ENCODING_QUOTEDPRINTABLE, $this->filters) !== FALSE) break; | |||
There was a problem hiding this comment.
… it in the code. Also added unit test
weierophinney
added a commit
that referenced
this pull request
Mar 3, 2014
fix #5428 only read the stream contents once
weierophinney
added a commit
that referenced
this pull request
Mar 3, 2014
- Braces, whitespace. - Incorrect variable references in tests caused them to fail; fixing them makes them pass.
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
…n/issue-5428-fix fix zendframework/zendframework#5428 only read the stream contents once
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
- Braces, whitespace. - Incorrect variable references in tests caused them to fail; fixing them makes them pass.
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-mime
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A suggestion for a fix. I think the getRawContent might also need the change.