Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox #5562

bacinsky · 2013-12-02T14:28:43Z

It could be nice to have such a method to remove a value option from a form element in runtime.

Instead of this in the user land:

$valueOptions = $element->getValueOptions();
if (isset($valueOptions['something'])) {
    unset($valueOptions['something']);
    $element->setValueOptions($valueOptions);
}

just this:

$element->unsetValueOption('something');

samsonasik · 2013-12-01T22:31:49Z

+1

…MultiCheckbox

samsonasik · 2013-12-03T15:09:20Z

library/Zend/Form/Element/MultiCheckbox.php

@@ -72,6 +72,19 @@ public function setValueOptions(array $options)
    }

    /**
+     * @param string $key
+     * @return Select


@return self

…return

…return self

Maks3w · 2014-01-02T18:34:20Z

@bacinsky Please send a PR to zf2-documentation too

…ox_unset_value_option Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox

Close #5562

Added unsetValueOption() to the Form\Element\Select and Form\Element\…

5cf0e0d

…MultiCheckbox

samsonasik reviewed Dec 3, 2013
View reviewed changes

Updated Form\Element\Select & MultiCheckbox, fixed unsetValueOption() @…

1852f28

…return self

bacinsky mentioned this pull request Jan 4, 2014

Adds unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox zendframework/zf2-documentation#1176

Closed

weierophinney added this to the 2.3.0 milestone Mar 3, 2014

weierophinney self-assigned this Mar 4, 2014

weierophinney added a commit that referenced this pull request Mar 4, 2014

Merge pull request #5562 from bacinsky/feature/select_and_multicheckb…

6205589

…ox_unset_value_option Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox

weierophinney added a commit that referenced this pull request Mar 4, 2014

Merge branch 'feature/5562' into develop

4a2d96a

Close #5562

weierophinney merged commit 1852f28 into zendframework:develop Mar 4, 2014

bacinsky deleted the feature/select_and_multicheckbox_unset_value_option branch March 4, 2014 20:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox #5562

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox #5562

bacinsky commented Dec 2, 2013

samsonasik commented Dec 1, 2013

samsonasik Dec 3, 2013

Maks3w commented Jan 2, 2014

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox #5562

Add unsetValueOption() to the Form\Element\Select and Form\Element\MultiCheckbox #5562

Conversation

bacinsky commented Dec 2, 2013

samsonasik commented Dec 1, 2013

samsonasik Dec 3, 2013

Choose a reason for hiding this comment

Maks3w commented Jan 2, 2014