This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Issue 3249: FormFile does not allow "value" as an attribute #5425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do not merge yet. I'm not 100% sure yet, if it's not a BC break. Since there was test, which tested if there is a value set... |
|
I can not see a BC break, because the attribute is not used by browsers. (security restrictions) So: 👍 |
|
The problem with your approach is that the attribute is actually valid within HTML 4.01, XHTML 1.0/1.1, but is not allowed within HTML5. So removing it in all cases is probably not the right thing to do. |
|
@johnpatcher
And again:
You can not set a value, because it is always ignored! (in all Versions of HTML!) |
weierophinney
added a commit
that referenced
this pull request
Jan 3, 2014
Issue 3249: FormFile does not allow "value" as an attribute
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue #3249 for details
FileElement does not allow value as an attribute