This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Get ViewModel children by capture #5255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
October 4, 2013 17:34
| * @param bool $recursive search recursive through children, default true | ||
| * @return array | ||
| */ | ||
| public function getChildrenByCaptureTo($capture, $recursive = true); |
|
So I don't add it to the interface? |
|
@jaapio correct |
| * @param bool $recursive search recursive through children, default true | ||
| * @return array | ||
| */ | ||
| public function getChildrenByCaptureTo($capture, $recursive = true) |
There was a problem hiding this comment.
Alternate possibility: add a new interface, "RetrievableChildrenInterface" or similar, and have the ViewModel also implement that interface. That way we can combine the two interfaces (or have the ViewModelInterface extend it) in 3.0, and users can test for that interface prior to calling the method.
|
Sounds good, but before I start more modifications I would like to know if this will be merged any way. Because if you don't like our solution at all, it is better to close this pr. :-) |
|
@jaapio yes, I'll merge it after you make the changes. :) |
weierophinney
added a commit
that referenced
this pull request
Jan 3, 2014
Get ViewModel children by capture
weierophinney
added a commit
that referenced
this pull request
Jan 3, 2014
ghost
assigned
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
…/getChildrenByCapture Get ViewModel children by capture
weierophinney
added a commit
to zendframework/zend-view
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to add new content to the page view model using a listener. But in the MvcEvent pass to the listeners the view model is always the complete layout ViewModel and not only the page content model. So we needed a way to get a ViewModel by it's location in the template.