This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
Test for the getArrayCopy method in AbstractRestultSet #5089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you're using the `ArraySerializable` hydrator, then you will have a method called `getArrayCopy` in your row object, so allow `AbstractResultSet` to use it.
weierophinney
added a commit
that referenced
this pull request
Sep 9, 2013
Test for the getArrayCopy method in AbstractRestultSet
weierophinney
added a commit
that referenced
this pull request
Sep 9, 2013
ghost
assigned
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're using the
ArraySerializablehydrator, then you will have a method calledgetArrayCopyin your row object, However,AbstractResultSet::toArray()currently checks that your row is an instance ofArrayObjectand hence throws an exception.This PR changes
AbstractResultSet::toArray()to check for the method name instead, to match the way thatArraySerializable::extract()handles this.