Skip to content
This repository has been archived by the owner on Jan 8, 2020. It is now read-only.

Applied trim and strtolower to Gravatar email per Gravatar docs: https://en.gravatar.com/site/implement/hash/ #4976

Merged
merged 2 commits into from
Aug 18, 2013

Conversation

PHLAK
Copy link
Contributor

@PHLAK PHLAK commented Aug 16, 2013

Per the Gravatar docs, the provided email address should be trimmed of all preceding and trailing white space and converted to lowercase before being hashed. This PR adds that functionality to the ZF2 Gravatar function.

@Ocramius
Copy link
Member

@PHLAK tests!

@EvanDotPro
Copy link
Member

👍

EvanDotPro added a commit that referenced this pull request Aug 16, 2013
samsonasik added a commit to samsonasik/zf2 that referenced this pull request Aug 17, 2013
the new line happen after PR zendframework#4976 merged
@Maks3w
Copy link
Member

Maks3w commented Aug 18, 2013

@EvanDotPro There is something wrong with the merge commits e702a42 c21cd36. This commits claims to be this PR but the code is from other PR

@ghost ghost assigned EvanDotPro Aug 18, 2013
EvanDotPro added a commit that referenced this pull request Aug 18, 2013
This reverts commit c21cd36, reversing
changes made to 3138073.

I mistakingly fetched #4967 instead of #4976.
EvanDotPro added a commit that referenced this pull request Aug 18, 2013
This reverts commit e702a42, reversing
changes made to 0a74768.

I mistakingly fetched #4967 instead of #4976.
EvanDotPro added a commit that referenced this pull request Aug 18, 2013
Pull request #4976

Merge commit 'refs/pull/4976/head' of github.com:zendframework/zf2
EvanDotPro added a commit that referenced this pull request Aug 18, 2013
@EvanDotPro EvanDotPro merged commit 10868ae into zendframework:master Aug 18, 2013
@EvanDotPro
Copy link
Member

@Maks3w Thanks for pointing that out. Please see my comment here. I had transposed the 6 and the 7 in the PR # when fetching locally to merge, so it merged the wrong PR.

I've reverted and corrected this now, everything should be good.

gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015
gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015
Pull request zendframework/zendframework#4976

Merge commit 'refs/pull/4976/head' of github.com:zendframework/zf2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants