This repository has been archived by the owner on Jan 8, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
Make methods setUp and tearDown protected #4783
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
👍 |
2 similar comments
PHP allows extending classes to redefine visibility of methods as long as the new visibility is more permissive; I see no reason to change this, particularly as it's common practice to define these methods as public when writing test cases. |
Methods are never called from outside the object, in other words there is no need to be public. The second argument: from a protected to public can do always, and not the reverse; so get the error: "Access level to setUp () must be public" |
Does this cover all occurences? |
TestCase these are intended for use outside zf2. |
Cherry-picked into master and merged to develop. |
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
weierophinney
added a commit
to zendframework/zend-test
that referenced
this pull request
May 15, 2015
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In phpunit these methods is protected.