Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme preview should inject script in footer template for Theming v2 Themes #339

Open
abdul opened this issue May 31, 2020 · 0 comments
Open

Comments

@abdul
Copy link
Contributor

abdul commented May 31, 2020

The theme preview is injecting script.js in document_head template which was fine for theming_v1 based themes.

The theming_v2 themes will now have script.js at the end of the page. That means, people need to do some work to migrate their javascript to adopt to this new situation (script.js loads at the end), and test.

This must be fixed to make sure we can have similar (if not same) locally. The order of script matters a lot, and if it's not right it leads to issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant