instance variable accessor

Author: cryptomail

lib/zendesk_api/client.rb

@@ -31,7 +31,9 @@ class Client
     # @return [Array] Custom response callbacks
     attr_reader :callbacks
 
-    attr_reader :ticket_fields_metadata
+    def ticket_fields_metadata
+      @ticket_fields_metadata ||= []
+    end
 
     # Handles resources such as 'tickets'. Any options are passed to the underlying collection, except reload which disregards
     # memoization and creates a new Collection instance.

lib/zendesk_api/resources.rb

@@ -473,19 +473,19 @@ def initialize(ticket, _arr)
 
       def [](key)
         raise "Cannot find custom field #{key}, configuration ticket_fields_metadata is OFF" unless
-          @ticket.instance_variable_get("@client").instance_variable_get("@ticket_fields_metadata")
+          @ticket.instance_variable_get("@client").ticket_fields_metadata
         # Trap read access
-        fld = @ticket.instance_variable_get("@client").instance_variable_get("@ticket_fields_metadata").find { |val| val[:title] == key }
+        fld = @ticket.instance_variable_get("@client").ticket_fields_metadata.find { |val| val[:title] == key }
         raise "Cannot find custom field #{key}" unless fld
         cf = @ticket.custom_fields.find { |h| h[:id] == fld[:id] }
         cf ? cf[:value] : nil
       end
 
       def []=(key, value)
         raise "Cannot find custom field #{key}, configuration ticket_fields_metadata is OFF" unless
-          @ticket.instance_variable_get("@client").instance_variable_get("@ticket_fields_metadata")
+          @ticket.instance_variable_get("@client").ticket_fields_metadata
         # Trap write access
-        fld = @ticket.instance_variable_get("@client").instance_variable_get("@ticket_fields_metadata").find { |val| val[:title] == key }
+        fld = @ticket.instance_variable_get("@client").ticket_fields_metadata.find { |val| val[:title] == key }
         raise "Cannot find custom field #{key}" unless fld
         cf = @ticket.custom_fields.find { |h| h[:id] == fld[:id] } if @ticket.custom_fields
         if cf

spec/core/resources/custom_field_symbol_proxy_spec.rb

@@ -10,7 +10,7 @@
   end
   let(:client) do
     double("Client").tap do |c|
-      allow(c).to receive(:instance_variable_get).with("@ticket_fields_metadata").and_return(field_metadata)
+      allow(c).to receive(:ticket_fields_metadata).and_return(field_metadata)
     end
   end
   let(:ticket) do
@@ -85,7 +85,7 @@ def t.custom_fields
 
   describe "[] and []= with missing ticket_fields_metadata" do
     before do
-      allow(client).to receive(:instance_variable_get).with("@ticket_fields_metadata").and_return(nil)
+      allow(client).to receive(:ticket_fields_metadata).and_return(nil)
     end
 
     it "raises error for [] when ticket_fields_metadata is missing" do