Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask secrets in logs #3157

Open
zenbanffy opened this issue Jan 30, 2019 · 1 comment
Open

Mask secrets in logs #3157

zenbanffy opened this issue Jan 30, 2019 · 1 comment

Comments

@zenbanffy
Copy link

zenbanffy commented Jan 30, 2019

There is always a risk of leaking secrets to logs. It'd be cool if Samson could censor logs where secrets appear, to prevent accidental leakage, as well as flag those instances for further review.

@grosser
Copy link
Contributor

grosser commented Jan 30, 2019

Ideally it would do that check before printing each line too ?
Then should also do it for the consolidated log once the deploy is finished.
It would check all used secrets values against the log.

I'm a little worried that this will get expensive, but maybe it's not too bad.
Another issue would be that the flow of the deploy needs to change, since we then cannot simply replace the secrets but have to keep track of them (env used + commands used)

/cc @zendesk/bre

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants