Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tabs unloading with the feature disabled #3311

Open
4 tasks done
vicky5124 opened this issue Nov 30, 2024 · 8 comments
Open
4 tasks done

Tabs unloading with the feature disabled #3311

vicky5124 opened this issue Nov 30, 2024 · 8 comments
Labels
Bug twilight This issue occurs in the twilight branch!

Comments

@vicky5124
Copy link

vicky5124 commented Nov 30, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

When Zen is out of focus (not necessary, but it increases the chances), tabs in deactivated workspaces unload even when the feature is completely disabled.
Below there's a picture of all the relevant configuration entries that should disable unloading entirely, but they only prevent unloading on the active workspace, and keeps unloading tabs in the different workspaces, including pinned tabs that have an increased base weight.
Unloading often happens in the same order displayed in about:unloads, but only following the secondary weight (for the most part; it appears to be quite random, but it does mostly follow this metric), which is what allows the pinned tabs to get unloaded, as it is ignoring the base weight that would prevent them from being unloaded.
Furthermore, not all tabs in different workspaces get unloaded at once, as most often only a random choice of tabs (regardless of when they were last accessed) get unloaded, including pinned tabs (so, if there are 3 pinned tabs and 20 normal tabs in a workspace, having 1 pinned tab and 12 normal tabs getting unloaded is possible)

image

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

From at least 1.0.1-a.19 to 1.0.2-b.5, including the latest twilight

What platform are you seeing the problem on?

Linux

Relevant log output

No response

Copy link

dosubot bot commented Nov 30, 2024

I found a related discussion that might be helpful:

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added Bug twilight This issue occurs in the twilight branch! labels Nov 30, 2024
@vicky5124
Copy link
Author

It appears that the issue is related to having multiple profiles with different unloader settings, and the setting not being correctly fetched or stored (it can be reproduced when you select "restart later" when changing the setting)

Copy link

dosubot bot commented Jan 2, 2025

Hi, @vicky5124. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Tabs are unloading in deactivated workspaces in Zen, even when the feature is disabled.
  • The issue is specific to Linux platforms and does not occur on Mozilla Firefox.
  • You suggested the problem might be linked to multiple profiles with different unloader settings.
  • The issue persists when selecting "restart later" after changing settings.
  • A related discussion was shared but received negative feedback from you and @Anoms12.

Next Steps:

  • Please let us know if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 2, 2025
@vicky5124
Copy link
Author

The issue is due to conflicting unloader implementations. Tabs in different workspaces are hidden, and hidden tabs get unloaded from memory into disk after a while, which is default Firefox behaviour, behaviour which can be tweaked with extensions such as Tab Stash or Auto Tab Discard (these extensions can be used to solve the issue; install tab stash, configure the extension so it does not unload stashed tabs, and then remove the extension). This default Firefox behaviour overrides the behaviour implemented by the zen browser.
It is an issue that is still present in the latest twilight and will keep on getting worse with future Firefox updates, as they are implementing their own unloaded with behaviour that zen does not manage and will keep overriding the zen unloader.

@j14i
Copy link
Member

j14i commented Jan 2, 2025

Hi, does this happen in b.5 / t.6 ?

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 2, 2025
@vicky5124
Copy link
Author

It is an issue that is still present in the latest twilight

I have updated the original message with the versions it happens on

@j14i
Copy link
Member

j14i commented Jan 2, 2025

Alright thanks

@j14i j14i moved this from Triage to ToDo in Zen Browser - public roadmap Jan 2, 2025
@mauro-balades
Copy link
Member

These features are indeed profile-independent. Are you suggesting they shoudn't be or that they dont even work on the same profile? Sorry my english isn't that good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug twilight This issue occurs in the twilight branch!
Projects
Status: ToDo
Development

No branches or pull requests

3 participants