Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar (for tabs) with different sizes for elements whille expanding #3040

Closed
3 of 4 tasks
quxer opened this issue Nov 15, 2024 · 5 comments
Closed
3 of 4 tasks

Sidebar (for tabs) with different sizes for elements whille expanding #3040

quxer opened this issue Nov 15, 2024 · 5 comments
Labels

Comments

@quxer
Copy link

quxer commented Nov 15, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

When sidebar is set to collapsed mode with expanding on hover there are problems with button sizes.

With workspaces, while expanded workspace button has smaller hight, which causes all tabs to be shifted upwards. With many tabs it is so distracting and hard to click on the one you want. Profile button is shifted a little as well.

When I disable workspaces, then tabs while expading are shifted downwards. While collapsed profile button with separator are too high and go downwards too.

I tried reseting to default buttons placement, but it was worse with more buttons next to profile button. To add to that this shifting behaviour is from many versions ago, many from the start. Once it was almost fixed, but with new changes to placement of buttons it's got worse. It is almost like both versions of sidebar are different elements between which we are switching.

NoWorkspaces  Collapsed
NoWorkspaces  Expanded
Workspaces  Collapsed
Workspaces  Expanded

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.19

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Copy link

dosubot bot commented Nov 15, 2024

I found related discussions and issues that might be helpful:

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the Bug label Nov 15, 2024
@Gregoor
Copy link

Gregoor commented Nov 21, 2024

I liked the idea of using expand-on-hover but find it currently unusable due to the layout shift. Here is an idea for solving it:

When expand on hover is enabled:

  • Essentials should always (also when expanded) be rows, like regular tabs, so that they stay in position
  • Account and Workspace switcher should either also follow that formula or simply be hidden when collapsed (my personal preference)

@Lalit64
Copy link

Lalit64 commented Dec 8, 2024

@quxer Why is this not getting enough attention?

@quxer
Copy link
Author

quxer commented Dec 10, 2024

@quxer Why is this not getting enough attention?

I don't know. But probably with beta release and disabling expand on hover, this issue will be pushed down the line or forgotten.

Copy link

dosubot bot commented Jan 10, 2025

Hi, @quxer. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue involves a layout shift in the sidebar when expanded, affecting button sizes and usability.
  • I suggested potential solutions, including modifying hover detection logic.
  • @Gregoor proposed maintaining the position of essentials and account/workspace switchers.
  • @quxer speculated the issue might be overlooked due to the beta release and feature changes.

Next Steps:

  • Please let us know if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further input, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 10, 2025
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 20, 2025
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

3 participants