Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled new tab settings controls are invisible until you mouse over them #3037

Open
3 of 4 tasks
Smooth-E opened this issue Nov 15, 2024 · 8 comments
Open
3 of 4 tasks
Assignees
Labels

Comments

@Smooth-E
Copy link

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

Today I noticed the new "Weather" option was added to the new tab page and I wanted to disable it. Upon opening the options side pane I saw that this option has no switch, but when I moused over it, the switch appeared. Though, removing the mouse from this option's box makes the switch disappear again. When the option is turned off, the switch stays visible at all times. Later I discovered that this applies to all options in this pane.

Mouse over webpage
Option enabled
Mouse over the option box
Option enabled
Mouse over webpage
Option disabled
Switch is invisible Enabled switch is visible when moused over Disabled switch is visible at all times

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.19 (Firefox 132.0.1)

What platform are you seeing the problem on?

Windows

Relevant log output

No response

@rdbo
Copy link

rdbo commented Nov 16, 2024

On a side note, shouldn't the weather thing be disabled by default as well?
I just started testing the browser and found that odd

@Smooth-E
Copy link
Author

On a side note, shouldn't the weather thing be disabled by default as well? I just started testing the browser and found that odd

I don't think so. When you bring a new feature into your project you either enable it by default if its a quality of life feature, or make an introduction pop-up of some sort, if it is a more focused change, to make those who may need such focused feature aware of it. The weather widget is easy to disable and most people will appreciate additional info on their new tab page, in my opinion

@rdbo
Copy link

rdbo commented Nov 17, 2024

The weather widget is easy to disable

True, I just brought it up because since privacy seems to be a big thing here, would be weird to ping a third party service by default and show your city location
Also it seems that this weather thing is actually done by Firefox and not Zen (correct me if I'm wrong), so maybe they will consider disabling it in the future

Copy link

dosubot bot commented Dec 18, 2024

Hi, @Smooth-E. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue involves invisible toggle switches for new tab settings in the Firefox extension on Windows with version 1.0.1-a.19.
  • @rdbo raised a concern about the weather widget being enabled by default, suggesting it might conflict with privacy expectations.
  • You responded that the widget is a quality of life feature and easy to disable, while @rdbo noted potential privacy issues with third-party services.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here to keep the discussion open.
  • If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 18, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 25, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 25, 2024
@Smooth-E
Copy link
Author

Hi, @Smooth-E. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

* The issue involves invisible toggle switches for new tab settings in the Firefox extension on Windows with version 1.0.1-a.19.

* @rdbo raised a concern about the weather widget being enabled by default, suggesting it might conflict with privacy expectations.

* You responded that the widget is a quality of life feature and easy to disable, while @rdbo noted potential privacy issues with third-party services.

Next Steps:

* Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here to keep the discussion open.

* If there is no further activity, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

Skipped this comment from the bot. The issue is still present on 1.0.2-b.5.

@dosubot, consider reopening this issue.

@dosubot dosubot bot reopened this Dec 25, 2024
Copy link

dosubot bot commented Dec 25, 2024

@mr-cheff, the user has indicated that the issue with invisible toggle switches for new tab settings in the Firefox extension is still present on version 1.0.2-b.5. Could you please take a look and assist them with this?

Copy link

dosubot bot commented Dec 25, 2024

The issue with invisible toggle switches in the new tab settings pane is related to missing CSS styles for .toggle-button[aria-pressed="true"]. To resolve this, ensure that the correct CSS styles are applied, including the --toggle-background-color-pressed variable and transparent border-color [1].

Regarding the weather widget, it is enabled by default through the preference setting pref("browser.newtabpage.activity-stream.system.showWeather", true); [2]. If privacy is a concern, you might consider disabling it manually until further changes are made to the default settings.

To continue talking to Dosu, mention @dosu.


Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Other

@Smooth-E
Copy link
Author

@mr-cheff, the user has indicated that the issue with invisible toggle switches for new tab settings in the Firefox extension is still present on version 1.0.2-b.5. Could you please take a look and assist them with this?

A small correction to avoid confusion. This is the default Zen's "New Tab" page, and not some kind of extension.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Triage
Development

No branches or pull requests

3 participants