Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Zen-split-view-modifier-header" is displayed instead of proper header in settings "Look and Feel" tab #2996

Closed
4 tasks done
leokostarev opened this issue Nov 13, 2024 · 2 comments
Labels

Comments

@leokostarev
Copy link

leokostarev commented Nov 13, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

When browser language is set to English (GB)
"Zen-split-view-modifier-header" is displayed in settings, seems like translation is missing

image

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.19 (Firefox 132.0.1)

What platform are you seeing the problem on?

Windows

Relevant log output

No response

@Anoms12
Copy link

Anoms12 commented Nov 13, 2024

I just created a pull request for it, I will keep you updated!

Pull Request

Edit: the pull request was already made 3 days ago, should have looked a bit harder, updated URL

Copy link

dosubot bot commented Dec 14, 2024

Hi, @leokostarev. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue involves a missing translation in the "Look and Feel" tab, where "Zen-split-view-modifier-header" is incorrectly displayed.
  • This occurs when the browser language is set to English (GB) on version 1.0.1-a.19 of the software on Windows.
  • Anoms12 mentioned a pull request was created to address this issue, and it was made three days prior to their comment.
  • The issue does not occur on Mozilla Firefox.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the desktop repository. If it is, you can keep the discussion open by commenting on the issue.
  • Otherwise, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 14, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 21, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Done
Development

No branches or pull requests

2 participants