Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zen sidebars bug #2818

Closed
4 tasks done
claymorwan opened this issue Nov 10, 2024 · 1 comment
Closed
4 tasks done

Zen sidebars bug #2818

claymorwan opened this issue Nov 10, 2024 · 1 comment
Labels

Comments

@claymorwan
Copy link

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

After the new 1.0.1-a.18 update, I've found 3 bugs with the sidebar:

  1. The toolbar doesn't go away when opening the sidebar.
    image
  2. The sidebar's button look odd.
    image
  3. The button to open the sidebar can't be moved or removed from the toolbar anymore, maybe it's a feature but I find it a bit annoying since it's more of a movable button.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.18

What platform are you seeing the problem on?

Linux

Relevant log output

No response

Copy link

dosubot bot commented Nov 10, 2024

Hey @claymorwan! I'm here to help you with any bugs, questions, or contributions. Let's tackle this together!

I found a similar closed issue that might be related to the sidebar button's appearance: Sidebar buttons pushed to left when collapsed. The solution suggested there was to add an align-items: center to correct the alignment issue [1].

Regarding the 1.0.1-a.18 update, several changes could affect the sidebar functionality:

  1. Hover Detection and Sidebar Expansion: The sidebar's state is managed based on hover detection and expansion preferences. If the sidebar is expanded, hover detection is disabled [2].

  2. Toggle Sidebar Expansion: The method for toggling the sidebar's expanded state and hover detection has been updated [2].

  3. Sidebar Positioning: The order of elements within the sidebar is adjusted dynamically, which could affect the layout and interaction [2].

For the issue with the toolbar not going away, it might be related to CSS properties applied to the sidebar and toolbar elements. Fixed height constraints and padding/margin adjustments could cause layout issues [3].

The inability to move or remove the sidebar button might be due to changes in how the sidebar button's position and behavior are managed. The ZenSidebarManager module handles the sidebar's open/close behavior, and changes in this module might have affected the button's movability [4].

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the Bug label Nov 10, 2024
@LeMoonStar LeMoonStar moved this from Triage to ToDo in Zen Browser - public roadmap Nov 10, 2024
@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 11, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 18, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

No branches or pull requests

1 participant