Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glance jumps to the first unpinned tab #2660

Closed
4 tasks done
Tealk opened this issue Nov 5, 2024 · 6 comments
Closed
4 tasks done

Glance jumps to the first unpinned tab #2660

Tealk opened this issue Nov 5, 2024 · 6 comments
Labels

Comments

@Tealk
Copy link

Tealk commented Nov 5, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

If I use Glance on a pinned tab and close the Glance window again, it jumps to the first unpinned tab.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.17

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Copy link

dosubot bot commented Nov 5, 2024

The behavior where Glance jumps to the first unpinned tab after closing the Glance window on a pinned tab in version 1.0.1-a.17 on Windows is due to the logic in the closeGlance method. When closeGlance is called, it checks if the current tab is the selected tab and advances the selected tab by one if it is. This logic is intended to skip the current tab, which can result in the selection moving to the first unpinned tab if the current tab is pinned [1].

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the Bug label Nov 5, 2024
@radiosilence
Copy link

I am experiencing this on any tab, if I close a glance, it always skips to the next tab.

@Tealk
Copy link
Author

Tealk commented Nov 5, 2024

You're right
I was able to reproduce it on Linux too.

@MrPiggy105
Copy link

Can confirm this on macOS 1.0.1-a.17 (Firefox 132.0, aarch64), even if you close it. There is also another bug for glance on pinned tabs, I'll make a new issue.

@RayZ3R0
Copy link

RayZ3R0 commented Nov 7, 2024

Duplicate of #(I dunno man, no one checks for duplicates so there's a lot). Closing as it will be fixed in a18 soon.

@Tealk
Copy link
Author

Tealk commented Nov 7, 2024

Sorry I searched but found nothing for my keywords

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants