Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drag and drop for sidebar widening and shrinking is offset seems like can't widen sidebar. #2659

Closed
4 tasks done
mikedlr opened this issue Nov 5, 2024 · 5 comments
Closed
4 tasks done
Labels

Comments

@mikedlr
Copy link

mikedlr commented Nov 5, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

When I drag the width of the sidebar it doesn't start moving until I am quite a number of pixels to the right of the bar. This is slightly inconvenient, but also, before you realize what's happening it seems like drag doesn't work at all.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.17 (Firefox 132.0) (64-bit)

What platform are you seeing the problem on?

Linux

Relevant log output

No response

@mikedlr
Copy link
Author

mikedlr commented Nov 5, 2024

Video of issue:

Screencast.from.2024-11-05.10-29-35.webm

This is on a fresh profile where the only thing I have done is open some tabs and pin them.

(I can't get the pointer to capture in the video - in this, imagine a pointer that starts off at the edge of the sidebar, where it is clicked, moves to the level of the settings icons and only then does the sidebar start expanding)

@dosubot dosubot bot added the Bug label Nov 5, 2024
Copy link

dosubot bot commented Nov 5, 2024

Hey @mikedlr! I'm Dosu, a bot here to help you with bugs, questions, and contributions. Let's take a look at the issue together.

I couldn't find any specific known issues or comments in the codebase related to the sidebar resizing offset problem. However, there is an event listener for the sidebar's drag-and-drop resizing functionality. The handleSplitterMouseDown function handles the mouse down event on the sidebar splitter, initiating the resizing process. It adds a mousemove event listener to handle resizing as the mouse moves and a mouseup event listener to stop resizing when the mouse button is released [1].

Additionally, the CSS styles applied to the sidebar and its drag handle might affect the offset during resizing. For example, the transition on the width (transition: width 0.3s ease-in-out;) and the width constraints (min-width, max-width) could influence the resizing behavior [2].

If the issue persists, you might want to check if there are any platform-specific considerations for Linux that could affect the sidebar's resizing behavior, although I couldn't find any specific information on that.

To continue talking to Dosu, mention @dosu.

@mikedlr
Copy link
Author

mikedlr commented Nov 5, 2024

Okay, I lied. I had immediately experimented with setting

layout.css.devPixelsPerPx = 1.5

and this only triggers after doing that. That means it's likely a bug but likely a very obscure one.

Copy link

dosubot bot commented Dec 6, 2024

Hi, @mikedlr. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • The issue involves drag-and-drop functionality for resizing the sidebar on Linux using Firefox 132.0.
  • The drag action only starts after moving several pixels to the right of the sidebar.
  • You provided a video to demonstrate the issue.
  • The issue occurs after setting layout.css.devPixelsPerPx = 1.5, suggesting it might be a rare bug.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there is no further activity, I will automatically close this issue in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 6, 2024
@mikedlr
Copy link
Author

mikedlr commented Dec 6, 2024

tested in 1.0.1-a.22 (Firefox 132.0.1) (64-bit) and this issue seems to be fixed or at least does not reproduce for me.

@dosubot , please close this if you can.

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 6, 2024
@mikedlr mikedlr closed this as completed Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant