Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab name weird padding #2636

Closed
4 tasks done
wiraki opened this issue Nov 4, 2024 · 10 comments
Closed
4 tasks done

Tab name weird padding #2636

wiraki opened this issue Nov 4, 2024 · 10 comments
Labels

Comments

@wiraki
Copy link

wiraki commented Nov 4, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

The text and icons of tab is not properly aligned. See in the screenshot how the text is almost touching the bottom border of the active tab surrounding box:

image

Using the flatpak on linux.

I tried disabling all the zen mods, closing and re-opening the browser etc., but I couldn't figure out what is causing it.

Thanks for your efforts!!

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.17

What platform are you seeing the problem on?

Linux

Relevant log output

No response

Copy link

dosubot bot commented Nov 4, 2024

Hey @wiraki! 👋 I'm here to help you with any bugs, questions, or contributions. Let's tackle this issue together! Dosu

I found a couple of similar closed issues that might be relevant to the tab alignment problem you're experiencing:

  1. Poor visibility of active tabs in 1.0.1-a: This issue was resolved in version 1.0.1-a.2, which might suggest that updating to a newer version could help if you're not already on the latest one.

  2. Tab bar: misaligned icons and hover background: This was fixed with a specific commit that adjusted CSS styles, particularly removing certain position and display properties and changing border styles [1][2].

For your specific issue with the flatpak version on Linux, there might be differences in how CSS or UI rendering is handled compared to other installation methods, but I couldn't find specific documentation on this. It might be worth checking if there are any updates or patches available for the flatpak version that address this issue.

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the Bug label Nov 4, 2024
@Richard-Woessner
Copy link
Contributor

Hey @wiraki Im having trouble replicating this bug, can you send a screenshot of the entire browser?

@wiraki
Copy link
Author

wiraki commented Nov 4, 2024

Hey, thanks for the quick reaction. Here's a screenshot, took the opportunity to show the zen mods in case it's helpful. Although as mentioned, turning them all off did not solve the issue.

image

Now I just tried loading another profile with default settings, and the issue is gone there. So it must be some setting/customization in my profile that is causing it. Do you have any idea where I should look?

Edit: now with the screenshot

@Richard-Woessner
Copy link
Contributor

Okay I was trying to see why your tabs are so different from mine and I can see now you have a addon installed

https://zen-browser.app/mods/d8b79d4a-6cba-4495-9ff6-d6d30b0e94fe

Are you sure its turned off?

@wiraki
Copy link
Author

wiraki commented Nov 4, 2024

Yes, here is the same with mods off.

image

@Richard-Woessner
Copy link
Contributor

Okay so with the mod turned off it looks fine is that what you were asking?

@wiraki
Copy link
Author

wiraki commented Nov 4, 2024

Okay so with the mod turned off it looks fine is that what you were asking?

No, it doesn't. In my last screenshot, you can see that the icon and tab name is not centered vertically in the box that highlights which tab is selected.

However, I found what is causing it:

  1. Right click in empty UI space
  2. Select "Customize Toolbar"
  3. At the bottom, set density to "Compact"

It does say that it is not supported. I don't remember doing this, maybe it was a miss-click while customizing other things. Switching back to other densities fixes it 👍

@wiraki wiraki closed this as completed Nov 4, 2024
@Richard-Woessner
Copy link
Contributor

Ahh thank you and great job finding the issue. Definitely something we should consider. Thanks

@Richard-Woessner
Copy link
Contributor

Moving this to Todo so we can remove Firefox compact mode, as we do not support it.

Thanks @wiraki

Copy link

dosubot bot commented Dec 5, 2024

Hi, @wiraki. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • You reported a misalignment issue with text and icons in tab names on Linux using flatpak version 1.0.1-a.17.
  • The issue was not reproducible on Mozilla Firefox.
  • Investigation revealed the problem was due to setting the toolbar density to "Compact," which is unsupported.
  • Switching to other densities resolved the issue.
  • Future updates will address the unsupported compact mode.

Next Steps:

  • Please let me know if this issue is still relevant to the latest version of the desktop repository by commenting here.
  • If there are no further updates, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 5, 2024
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 12, 2024
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants