Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Glance window breaks Zen if closed with CTRL + W shortcut on Windows #2551

Closed
4 tasks done
Tomveloper opened this issue Nov 1, 2024 · 6 comments
Closed
4 tasks done
Labels

Comments

@Tomveloper
Copy link
Contributor

Tomveloper commented Nov 1, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

After opening a Glance, closing it using the close tab shortcut, CTRL + W, closes it but it also breaks Zen and makes you unable to switch tab or open a new Glance.

Steps to reproduce:

  1. Open a Glance.
  2. Press CTRL + W to close the Glance.

I would expect (and want) the Glance to close without any issues, just like when you close it normally using the X button.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.17 (64-bit)

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Copy link

dosubot bot commented Nov 1, 2024

Hey @Tomveloper! 👋 I'm here to help you with any bugs, questions, or contributions you have in mind. I'm a bot designed to assist you while you wait for a human maintainer.

The issue you're experiencing with the Glance window breaking Zen when closed using the CTRL + W shortcut might be related to how the application handles tab management and switching. Unfortunately, I couldn't find specific information on how the CTRL + W shortcut is implemented or managed within the codebase. However, the Glance window lifecycle is managed by the following modules:

  • content/browser/zen-components/ZenGlanceManager.mjs
  • content/browser/zen-components/actors/ZenGlanceChild.sys.mjs
  • content/browser/zen-components/actors/ZenGlanceParent.sys.mjs [1].

You might want to investigate these modules to understand how the Glance window is managed and how the CTRL + W shortcut might be affecting its behavior. Additionally, checking for any error handling mechanisms in these modules could provide insights into why the application breaks when using the shortcut.

To continue talking to Dosu, mention @dosu.

@BredMan0
Copy link

BredMan0 commented Nov 1, 2024

This same issue happens on Linux too.

Screencast_2024-11-01_17-27-05.mp4

@BredMan0
Copy link

BredMan0 commented Nov 1, 2024

Just checked, this issue has actually already been mentioned in #2526 too.

@Tomveloper
Copy link
Contributor Author

Just checked, this issue has actually already been mentioned in #2526 too.

Oh sorry, I saw the video and it didn't showcase the bug so I assumed they were talking about something else.

@beauwright
Copy link

I have this issue too on macOS aarch64

@Tomveloper
Copy link
Contributor Author

I have this issue too on macOS aarch64

It is fixed in Zen Twilight, the nightly version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants