The fullscreen button and close button in glance both close the window.

[Shockshwat]

Captchas

• I have read the instructions.
• I have searched existing issues and avoided creating duplicates.
• I am not filing an enhancement request.

What happened?

I saw the changelog of a17 and thought something changed regarding the fullscreen button of glance so i decided to check it out when i discovered that close button and fullscreen button both do the same thing. I expected the fullscreen button to "seamlessly"(what i understood from the changelog) well fullscreen the tab.

Edit: I am on Zen browser and the attached video is showing corrupt for me, I tried to look at it using my smartphone and the video loads fine, I don't know if that's a bug or a configuration issue on my side but you face the same issue while trying to play the video please try loading it in another browser or smartphone.

2024-11-01.13-17-26.mp4

Reproducible?

• I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.17

What platform are you seeing the problem on?

Windows

Relevant log output

No response

[dosubot]

Hey @Shockshwat! I'm here to help you with any bugs, questions, or contributions you might have. Let's work on getting this sorted out together.

The issue you're experiencing with the fullscreen and close buttons in the Glance feature both closing the window seems to be a bug. The expected behavior, as you mentioned, is for the fullscreen button to actually make the tab fullscreen. The UI components for these buttons are toolbarbutton elements with the class toolbarbutton-1 ^[1]. It might be worth checking if there are any event listeners or handlers incorrectly assigned to these buttons, causing them to perform the same action.

To continue talking to Dosu, mention @dosu.

[RayZ3R0]

Video_2024-11-01_16-13-00.mp4

That's not how its happening for me though, But yeah there are still a lot of bugs in glance, maybe it'll be fixed with those

[JSGRD22]

Similar issue here. However, for me it seems that the button hitboxes are actually not present at all, and attempting to click them just clicks outside the glance box and closes it. This is evident as the buttons are not highlighted when hovering over them.

[Shockshwat]

Update with a18, Now the icons are missing too.

[dosubot]

Hi, @Shockshwat. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

• You reported an issue with the Glance feature where both the fullscreen and close buttons close the window instead of expanding it.
• I suggested checking for incorrectly assigned event listeners on the buttons.
• RayZ3R0 did not experience the same issue but noted other bugs in Glance.
• JSGRD22 mentioned that button hitboxes seem absent, causing clicks to close the window.
• You later updated that the icons for the buttons are now missing in the latest update.

Next Steps:

• Please let us know if this issue is still relevant to the latest version of the desktop repository by commenting here.
• If there is no further activity, this issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

[JSGRD22]

Issue is no longer present