Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fading edge effect on the tab sidebar does not apply to entries below (and including) the selected tab #2516

Open
4 tasks done
Smooth-E opened this issue Nov 1, 2024 · 6 comments
Labels

Comments

@Smooth-E
Copy link

Smooth-E commented Nov 1, 2024

Captchas

  • I have read the instructions.
  • I have searched existing issues and avoided creating duplicates.
  • I am not filing an enhancement request.

What happened?

There is a so called "fading edge" effect applied at the bottom of the vertical tab pane when there are too much tabs and the list is overflowing. This "fading edge" strip isn't rendered when you scroll past the selected tab.

The selected tab is below and isn't yet visible The selected tab is above
Selected tab below Selected tab above
As you can see, names and icons of the tabs are faded with a smooth gradient As you can see, name and icon of the tab are just cut out where list's viewport ends

Also, this may fall into the "enhancement request" category, but there is no such "fading edge" at the top of the tab strip. I think, it would be nice to add it there too.

Checking as not reproducible on Firefox as vertical tab pane is unique to Zen.

Reproducible?

  • I have checked that this issue cannot be reproduced on Mozilla Firefox.

Version

1.0.1-a.16

What platform are you seeing the problem on?

Windows

Relevant log output

No response

Copy link

dosubot bot commented Nov 1, 2024

I couldn't find specific information about the "fading edge" effect in the tab sidebar within the repository. However, the CSS file src/browser/base/content/zen-styles/zen-tabs/vertical-tabs.css is responsible for rendering the tab sidebar and its effects, which might include the "fading edge" effect. Additionally, the JavaScript file src/browser/components/sidebar/browser-sidebar.js manages the positioning and ordering of elements within the sidebar, potentially affecting how the "fading edge" is applied [1][2].

If you're experiencing issues with the "fading edge" effect not applying correctly, it might be worth checking these files for any relevant styles or scripts that could be causing the issue.

To continue talking to Dosu, mention @dosu.

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 2, 2024
@salamijason
Copy link

Hey do you still get this visual bug on a22?

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Dec 2, 2024
@Smooth-E
Copy link
Author

Smooth-E commented Dec 4, 2024

Hey do you still get this visual bug on a22?

Yes. Same issue: no fading edge below selected tab on the bottom, no fading edge at all on the top. I am using the default light theme.

@salamijason
Copy link

Was able to recreate on our end. will be sending to big dev cheff. Thanks for the info!

@salamijason salamijason moved this from Triage to ToDo in Zen Browser - public roadmap Dec 10, 2024
Copy link

dosubot bot commented Jan 10, 2025

Hi, @Smooth-E. I'm Dosu, and I'm helping the desktop team manage their backlog. I'm marking this issue as stale.

Issue Summary:

  • Issue with "fading edge" effect on tab sidebar in version 1.0.1-a.16 on Windows.
  • I suggested checking CSS and JavaScript files.
  • You confirmed the issue persists in version a22.
  • Salamijason recreated the issue and plans to escalate it to the development team.

Next Steps:

  • Please confirm if this issue is still relevant to the latest version of the desktop repository.
  • If no further updates are provided, the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution!

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 10, 2025
@Smooth-E
Copy link
Author

Smooth-E commented Jan 10, 2025

Well. Here's an update: now there is no "fading edge" effect neither when the select tab is above or below the bottom button group. There is also no such effect for the top button group. It is an improvement in terms of consistency, but I think a fading edge effect is a good addition to indicate there are items below or above, and you need to scroll to see them.

Edit: Browser version is 1.6b.

@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Jan 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: ToDo
Development

No branches or pull requests

2 participants