Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: simplify stringExcel formatter and support proper escaping #513

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix: simplify stringExcel formatter and support proper escaping #513

merged 1 commit into from
Jan 28, 2021

Conversation

juanjoDiaz
Copy link
Collaborator

Fixes #511 and simplify the excel formatter.

It makes no sense to use the excel formatter with custom quotes or escaped quotes.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling e820b4d on juanjoDiaz:escape_quotes_excel_v6 into 5c62da1 on zemirco:master.

@knownasilya knownasilya merged commit 50062c3 into zemirco:master Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

excelStrings option works incorrectly with quoted values
3 participants