Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: prevents Parser and AsyncParser from caching the fields option b… #498

Merged
merged 1 commit into from
Nov 10, 2020
Merged

fix: prevents Parser and AsyncParser from caching the fields option b… #498

merged 1 commit into from
Nov 10, 2020

Conversation

juanjoDiaz
Copy link
Collaborator

…etween executions causing issues and inconsistencies

Closes #495

@juanjoDiaz
fix: prevents Parser and AsyncParser from caching the fields option b…
24945e9 
…etween executions causing issues and inconsistencies
@juanjoDiaz
Copy link
Collaborator Author

I don't think that we need to backport this to v5

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 24945e9 on juanjoDiaz:fix_caching_of_fields into bcce91f on zemirco:master.

@knownasilya knownasilya merged commit 4d8a81a into zemirco:master Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Parsers cache the fields option even if it's not explicitly passed
3 participants
@juanjoDiaz @coveralls @knownasilya