Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI node versions #413

Merged
merged 1 commit into from
Aug 19, 2019
Merged

Update CI node versions #413

merged 1 commit into from
Aug 19, 2019

Conversation

juanjoDiaz
Copy link
Collaborator

Drop node 6 and 7, and add node 11 and 12

Closes #409

Drop node 6 and 7, and add node 11 and 12
@juanjoDiaz
Copy link
Collaborator Author

@knownasilya do you think that this should go to v5.0?

In that case, we should merge this but not release then I can do all the proposed changes for v5.0 and then release.

Wdyt?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling a074ec9 on juanjoDiaz:update_ci_node_versions into b57715b on zemirco:master.

@knownasilya
Copy link
Collaborator

Yeah

@knownasilya knownasilya merged commit 997e298 into zemirco:master Aug 19, 2019
knownasilya pushed a commit that referenced this pull request Aug 19, 2019
BREAKING CHANGE: Drop node 6 and 7, and add node 11 and 12
@juanjoDiaz juanjoDiaz deleted the update_ci_node_versions branch September 4, 2019 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sunset node v6 & v7 support
3 participants