Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of json2csv.cjs.js #391

Closed
juanjoDiaz opened this issue Apr 30, 2019 · 1 comment · Fixed by #422
Closed

Get rid of json2csv.cjs.js #391

juanjoDiaz opened this issue Apr 30, 2019 · 1 comment · Fixed by #422
Labels
enhancement
Milestone
v5

Comments

@juanjoDiaz
Copy link
Collaborator

It's an unnecessary compilation step.

lib/json2csv.js can be used instead.
@juanjoDiaz juanjoDiaz added this to the v5 milestone Apr 30, 2019
@knownasilya
Copy link
Collaborator

Unless we want to use babel features (or TS) not supported in node versions we support. But probably not.

@juanjoDiaz juanjoDiaz mentioned this issue Sep 9, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
v5
Development

Successfully merging a pull request may close this issue.

Remove CommonJS build
2 participants
@knownasilya @juanjoDiaz