Optimize performance around the usage of fields #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 similar comments
knownasilya
reviewed
Sep 24, 2018
lib/JSON2CSVBase.js
Outdated
| /** | ||
| * Check and normalize the fields configuration. | ||
| * | ||
| * @param {String|FieldInfo} fields Fields configuration provided by the user |
There was a problem hiding this comment.
Should this be an array of String|FieldInfo?
|
You are right! It should be good now. I need to review all the comments tho. I don't think they are 100% correct. I'll do it in a separate PR. |
|
Available in v4.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were running all the logic around fields, labels, etc. on each row.
With this change, it is run only once at the beginning.
It also corrects a small bug that I found were an empty number was set as
"".