Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove node 4 and 5 support, End-Of-Life #303

Closed
knownasilya opened this issue Jun 11, 2018 · 4 comments
Closed

Remove node 4 and 5 support, End-Of-Life #303

knownasilya opened this issue Jun 11, 2018 · 4 comments
Milestone

Comments

@knownasilya
Copy link
Collaborator

The Node org has ended support for Node 4 in April and Node 5 in 2016, so we shouldn't be supporting these. Also the new maintained cli-table3 only supports node 6+.

https://github.com/nodejs/Release/blob/643af71ee8365efbdccaa134690425ea05931279/README.md#release-schedule

@knownasilya knownasilya added this to the v5 milestone Jun 11, 2018
@juanjoDiaz
Copy link
Collaborator

I'm not sure if adding a library that was recently created and it's only tangentially used in json2csv really justifies a major version bump.

I was planning to create a very simple table cli just for our use case.
Another option would be to use a widely used table like https://www.npmjs.com/package/table since we don't need the multiple row/col span that's the main selling point of cli-table2 and I assume 3.

Wdyt?

@knownasilya
Copy link
Collaborator Author

I'm fine either way, but I think it still stands that we shouldn't be supporting a node version that Node itself doesn't.

I can actually see us doing something like json2csv ... | csv-table as a better solution. But in the end we will see more issues with Node 4 no matter what we use for table printing.

@juanjoDiaz
Copy link
Collaborator

Just give me a day or so and I'll come back with a simpler proposal for the pretty print :)

Regarding deprecating node 4 and 5. I have no problem with that. But I don't see a problem keeping it until we have to change it either. After all, people still use Node 0.10 :)

@knownasilya
Copy link
Collaborator Author

Yeah, and people still use Windows XP, doesn't mean they should haha :trollface:

Sounds good regarding the pretty print

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants