Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix error when a field is null and flatten is used #274

Merged
merged 1 commit into from
Apr 2, 2018
Merged

Fix error when a field is null and flatten is used #274

merged 1 commit into from
Apr 2, 2018

Conversation

juanjoDiaz
Copy link
Collaborator

Closes #273

@coveralls
Copy link

coveralls commented Mar 21, 2018

Coverage Status

Coverage remained the same at 100.0% when pulling d4ae494 on juanjoDiaz:fix_null_error_on_flatten into e3ebed6 on zemirco:master.

@juanjoDiaz
Copy link
Collaborator Author

What the hell?!?! It seems that the table library decided to include colors in some older node? That's weird...

I'll have to check it.

Help is welcome :)

@juanjoDiaz
Copy link
Collaborator Author

Ok, so it's nothing to do with the code. Master also fails now: https://travis-ci.org/zemirco/json2csv/jobs/359058666

Has anything changed in Travis @knownasilya ?

@knownasilya
Copy link
Collaborator

Not that I'm aware of, maybe they updated the images..

@juanjoDiaz
Copy link
Collaborator Author

I removed all the colors introduced by table-cli2 (which are the tests failing) but the error persists.
So I'm totally clueless about what's including the colors all the sudden.

I had spent 2 weeks researching this and have no answer. Since master is already failing and this PR definitely work and is 100% unrelated to the failing tests, I'd suggest that we merge this and I'll create a new issue for the failing tests. 😞

@knownasilya knownasilya merged commit 1349a94 into zemirco:master Apr 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants