Refactor the entire library to ES6 #233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knownasilya
reviewed
Jan 25, 2018
README.md
Outdated
|
|
||
| var csv = json2csv({ data: myCars, fields: fields }); | ||
| const csv = json2csv({ data: myCars, fields: fields }); |
There was a problem hiding this comment.
This example doesn't seem to be using the new data parameter.
|
Also looks like travis is failing due to a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alright. Here comes the madness.
Full refactor of the library to a more modular architecture and ES6.
All test passing and no functionality change.
The only change is that:
preserveNewLinesInValuesis gone. I don't see why we should by default be stripping characters from strings and have an option to don't do so.I have also half-way there the streaming API build on top of the methods introduced by the PR so I'll finish that and push it once this is merged.