No BOM character at the beginning of the csv

[AuroreM]

I used this library to create csv then opened with Excel and I encountered some issue with special characters :

I found that I had to add the BOM character U+FEFF at the beginning of the CSV string.
I've got a branch ready for a pull request to add a --with-BOM option :

But I can not push my branch. Could you help me please ?
(It's my first contribution to an open source repo :))

[4ian]

But I can not push my branch. Could you help me please ?
(It's my first contribution to an open source repo :))

The way to submit pull requests with GitHub is to Fork the repository:

You'll have a fork for your username (https://github.com/AuroreM/json2csv). Then git clone your fork and do the changes in it (or add https://github.com/AuroreM/json2csv as a remote to your existing git repository where you've made the changes. Then push to that remote).

Once you have your branch pushed in your fork you can open a Pull Request and GitHub will show your branch or your fork. :)

[AuroreM]

Thanks @4ian, the Pull Request is opened : #187 :)

[knownasilya]

Ah, missed this issue. Thanks for catching this.