Parameter unwindPath for multiple fields (#174) #183
Conversation
README.md
Outdated
| var fields = ['carModel', 'price', 'items.name', 'items.color', 'items.items.position', 'items.items.color']; | ||
| var myCars = [ | ||
| { | ||
| "carModel": "BMW", |
There was a problem hiding this comment.
Could you make the spacing 2 spaces instead of the 4 or tabs that it currently is. Just so it's consistent with the other examples. Thanks!
lib/json2csv.js
Outdated
| @@ -99,7 +99,7 @@ function checkParams(params) { | |||
| return Object.keys(item); | |||
| }); | |||
|
|
|||
| dataFields = lodashFlatten(dataFields); | |||
| dataFields = lodashFlatten(dataFields);//_.flattenDeep(params.data);// | |||
There was a problem hiding this comment.
Should the flattenDeep be used or removed?
lib/json2csv.js
Outdated
| if (params.unwindPath) { | ||
| function createDataRows(originalData, unwindPaths) { | ||
| var dataRows = originalData; | ||
| if (unwindPaths.length) { | ||
| dataRows = []; |
There was a problem hiding this comment.
Looks like dataRows gets overwritten right away, why not set it to an empty array on line 297, and just return originalData if unwindPaths.length is falsy.
| params.unwindPath = params.unwindPath || []; | ||
|
|
||
| // if unwindPath is not in array [{}], then just create 1 item array. | ||
| if (!Array.isArray(params.unwindPath)) { |
There was a problem hiding this comment.
Actually this part of code, make the change compatible with old single string parameter. I have not extensively tested, but it should work fine. So I would say no breaking changes.
lib/json2csv.js
Outdated
| @@ -307,6 +305,8 @@ function createDataRows(originalData, unwindPaths) { | |||
|
|
|||
| Array.prototype.push.apply(dataRows, dataRow); | |||
There was a problem hiding this comment.
Is this necessary? Should be able to do dataRows.push(dataRow)
There was a problem hiding this comment.
This is actually necessary. Check out this link, but basically we need to merge two arrays (dataRows and dataRow).
There was a problem hiding this comment.
Sorry, I missed that it was an apply and not a call.
This relates to #174. It adds functionalities as described below: