Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Error handling #61

Closed
imsnif opened this issue Nov 19, 2020 · 2 comments · Fixed by #83
Closed

Implement Error handling #61

imsnif opened this issue Nov 19, 2020 · 2 comments · Fixed by #83
Labels
help wanted Extra attention is needed

Comments

@imsnif
Copy link
Member

imsnif commented Nov 19, 2020

Right now we panic when there's an error. Since we do that inside a thread, it's very hard to tell what caused the error. This is especially true if the error we end up getting is an error from another thread that fails to send a message to the panicked thread.

We need some system that would (among other things) allow us to get proper errors across our threads. This will greatly ease development.

@imsnif imsnif added the help wanted Extra attention is needed label Nov 19, 2020
@kunalmohan
Copy link
Member

I would like to work on this issue 😃. Will start in a couple of days(as discussed on discord).

@roee-shapira-tikal
Copy link

@kunalmohan I used panic::set_hook to try and fix this error two of the tests, it might help you too...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants