Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v0.38] ToggleFocusFullscreen not working with Run anymore #2752

Closed
utkarshgupta137 opened this issue Aug 30, 2023 · 2 comments · Fixed by #2757
Closed

[v0.38] ToggleFocusFullscreen not working with Run anymore #2752

utkarshgupta137 opened this issue Aug 30, 2023 · 2 comments · Fixed by #2757
Assignees

Comments

@utkarshgupta137
Copy link

Basic information
OS:
zellij --version: 0.38 (latest)
stty size: 65 240
uname -av or ver(Windows): Darwin utkarsh-mbp 22.5.0 Darwin Kernel Version 22.5.0: Thu Jun 8 22:22:20 PDT 2023; root:xnu-8796.121.3~7/RELEASE_ARM64_T6000 arm64

CLI:
nvim --version: 'NVIM v0.9.1
lazygit --version: commit=, build date=, build source=nix, version=0.40.2, os=darwin, arch=arm64, git version=2.39.2 (Apple Git-143)
alacritty --version: alacritty 0.12.2

Further information
Up until v0.37.2, the following binding:

    shared_except "locked" {
        bind "Alt g" {
            Run "lazygit" {
                close_on_exit true
            };
            ToggleFocusFullscreen;
        }
    }

Would result in lazygit opening in fullscreen. Now, it looks like the ToggleFocusFullscreen has no effect.

Weirdly, if I use the following binding after lazygit is opened:

    pane {
        bind "f" { ToggleFocusFullscreen; SwitchToMode "Normal"; }
    }

Then it makes it fullscreen.

@imsnif
Copy link
Member

imsnif commented Aug 31, 2023

Good catch!! Thanks for the quick report. I issued a fix, and will release a patch version with this and other stuff later today.

@utkarshgupta137
Copy link
Author

Thanks for the quick turnaround <3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants