Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The theme file in the themes directory is not recognized #1849

Closed
jaeheonji opened this issue Oct 25, 2022 · 5 comments · Fixed by #1855
Closed

The theme file in the themes directory is not recognized #1849

jaeheonji opened this issue Oct 25, 2022 · 5 comments · Fixed by #1855
Assignees

Comments

@jaeheonji
Copy link
Member

jaeheonji commented Oct 25, 2022

Basic information

zellij --version: zellij 0.32.0
stty size: 30 120
uname -av or ver(Windows): Linux Julian 5.10.102.1-microsoft-standard-WSL2 #1 SMP Wed Mar 2 00:30:59 UTC 2022 x86_64 GNU/Linux
windows terminal: 1.15.2875.0

Further information

After the config is converted to KDL, the theme file existing in the themes directory is not recognized.
Currently, only themes declared directly in config.kdl are recognized.

@jaeheonji jaeheonji self-assigned this Oct 25, 2022
@imsnif
Copy link
Member

imsnif commented Oct 25, 2022

Hey @jaeheonji - this works for me:

// ~/.config/zellij/themes/dracula.kdl
themes {
    dracula {
        fg 248 248 242
        bg 40 42 54
        black 0 0 0
        red 255 85 85
        green 80 250 123
        yellow 241 250 140
        blue 98 114 164
        magenta 255 121 198
        cyan 139 233 253
        white 255 255 255
        orange 255 184 108
    }
}
$ zellij options --theme dracula

Could you tell me more about your setup? Maybe we can find out what exactly isn't working?

@jaeheonji
Copy link
Member Author

jaeheonji commented Oct 25, 2022

Hey @jaeheonji - this works for me:

Oh, yes, it works. but,

// ~/.config/zellij/themes/catppuccin.kdl

themes {
    catppuccin-frappe {
        fg 198 208 245
        bg 98 104 128
        black 41 44 60
        red 231 130 132
        green 166 209 137
        yellow 229 200 144
        blue 140 170 238
        magenta 244 184 228
        cyan 153 209 219
        white 198 208 245
        orange 239 159 118
    }
    catppuccin-latte {
        fg 172 176 190
        bg 172 176 190
        black 76 79 105
        red 210 15 57
        green 64 160 43
        yellow 223 142 29
        blue 30 102 245
        magenta 234 118 203
        cyan 4 165 229
        white 220 224 232
        orange 254 100 11
    }
    catppuccin-macchiato {
        fg 202 211 245
        bg 91 96 120
        black 30 32 48
        red 237 135 150
        green 166 218 149
        yellow 238 212 159
        blue 138 173 244
        magenta 245 189 230
        cyan 145 215 227
        white 202 211 245
        orange 245 169 127
    }
    catppuccin-mocha {
        fg 205 214 244
        bg 88 91 112
        black 24 24 37
        red 243 139 168
        green 166 227 161
        yellow 249 226 175
        blue 137 180 250
        magenta 245 194 231
        cyan 137 220 235
        white 205 214 244
        orange 250 179 135
    }
}

and

$ zellij options --theme catppuccin-mocha

I tried this and it doesn't work.

I think it doesn't work if there are multiple themes in one file.

@jhseu
Copy link

jhseu commented Oct 26, 2022

Can confirm that after 0.32, it only works if:

  • There's only one theme in the file.
  • The file is named after the theme.

@imsnif
Copy link
Member

imsnif commented Oct 26, 2022

Hey - apologies for this bug. I didn't know more than one theme in a custom theme file was possible :(
I think @jaeheonji said he is fixing it - right?

@jaeheonji
Copy link
Member Author

@imsnif Yes, I will fix it ASAP :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants