Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issue for server stability (old 1) #1100

Closed
18 tasks done
raphCode opened this issue Feb 23, 2022 · 5 comments
Closed
18 tasks done

Tracking issue for server stability (old 1) #1100

raphCode opened this issue Feb 23, 2022 · 5 comments
Labels
stability Issues in relation to stability

Comments

@raphCode
Copy link
Contributor

raphCode commented Feb 23, 2022

Here I collect open issues related to zellij server stability, meaning problems that may cause sessions to crash or become otherwise unuseable. Currently, I limit this list to issues where active work can get lost, e.g. a new session crashing directly at startup is out of scope.

Server crashes

Inaccessible session / corruption

I suggest to keep comments to their respective issues instead of here, to keep this tracking issue "clean" of crash details.

Feel free to ping me in other / new issues if I should update this list.

@jaeheonji
Copy link
Member

Thank you so much for your hard work! this is really cool 👍

@raphCode
Copy link
Contributor Author

raphCode commented Feb 23, 2022

Ideally, we can fix panics / crashes before they occur to users.
For this, we should make most / all server code that interacts with syscalls and the wasm plugin system fail gracefully instead of panicing.
The rest of the possible panics are probably internal logic bugs anyway.

I am not sure on how to approach that - should I spam a bunch of new issues for all the potentially offending code locations I can find?

@jaeheonji
Copy link
Member

jaeheonji commented Feb 23, 2022

First of all, I personally think that the key to this problem is the unexpected unwrap code.

The intentional panic code is a necessary part (currently about 10-15 lines of the entire code) and I'm working on an error-reporting system for it.

However, verifying all unwrap code is very difficult. "ideally" we should fix the error before the user sees it, but in the end, it's natural to get feedback from users and fix it.

So I think the purpose of this issue is to gather stability-related issues from new issues.
And we'll just have to add the problems we find naturally in developing.

should I spam a bunch of new issues for all the potentially offending code locations I can find?

I think it would be fine to organize small-scale code into markdown tables with permalink. and It would be nice to create a new issue and link to it only for those that need discussion and detail.

@a-kenji
Copy link
Contributor

a-kenji commented Jul 7, 2022

@raphCode,
Do you mind recreating the issue?
It is now a bit cluttered and we can still link back to this one.

@raphCode raphCode changed the title Tracking issue for server stability Tracking issue for server stability (old 1) Jul 7, 2022
@raphCode raphCode unpinned this issue Jul 7, 2022
@raphCode
Copy link
Contributor Author

raphCode commented Jul 7, 2022

The new issue is #1568

@raphCode raphCode closed this as completed Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stability Issues in relation to stability
Projects
None yet
Development

No branches or pull requests

3 participants